-
Notifications
You must be signed in to change notification settings - Fork 24.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] base: duration widget for unsupported babel format #155978
[FW][FIX] base: duration widget for unsupported babel format #155978
Conversation
@JKE-be @mart-e cherrypicking of pull request #155909 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
e01fa87
to
5f9ddd8
Compare
@robodoo r+ |
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale. Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing. python-babel/babel#827 X-original-commit: 7cc2436
5f9ddd8
to
56b6f08
Compare
@robodoo r+ |
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale. Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing. python-babel/babel#827 closes #155978 X-original-commit: 7cc2436 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Signed-off-by: Jérémy Kersten <jke@odoo.com>
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale. Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing. python-babel/babel#827 closes #155978 X-original-commit: 7cc2436 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com> Signed-off-by: Jérémy Kersten <jke@odoo.com>
In case of exception of type KeyError during the formatting with Babel instead to raise a Traceback, we first retry with the en_US locale.
Babel fixes each week new bug of formatting like the one in the test, but we cannot bump our default babel version since it is not in the stable Ubuntu 22 so it is a best effort fix that will not hide all bugs but is better that nothing.
python-babel/babel#827
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #155909